Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/cloudflare: Change cloudflare_record type to ForceNew #5353

Merged
merged 1 commit into from
Feb 27, 2016
Merged

provider/cloudflare: Change cloudflare_record type to ForceNew #5353

merged 1 commit into from
Feb 27, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 27, 2016

The CloudFlare API does not allow types to be changed (i.e. A to CNAME)
after creation

Fixes #5316

make testacc TEST=./builtin/providers/cloudflare TESTARGS='-run=TestAccCLOudflareRecord'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/cloudflare -v -run=TestAccCLOudflareRecord -timeout 120m
=== RUN   TestAccCLOudflareRecord_Basic
--- PASS: TestAccCLOudflareRecord_Basic (5.61s)
=== RUN   TestAccCLOudflareRecord_Updated
--- PASS: TestAccCLOudflareRecord_Updated (9.08s)
=== RUN   TestAccCLOudflareRecord_forceNewRecord
--- PASS: TestAccCLOudflareRecord_forceNewRecord (9.87s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/cloudflare 24.574s

@stack72
provider/cloudflare: Change cloudflare_record type to ForceNew. The
b8778b8 
CloudFlare API does not allow types to be changed (i.e. A to CNAME)
after creation
@jen20
Copy link
Contributor

jen20 commented Feb 27, 2016

LGTM pending Travis! Thanks @stack72

stack72 added a commit that referenced this pull request Feb 27, 2016
@stack72
Merge pull request #5353 from stack72/f-cloudflare-type-forcenew
c59303a 
provider/cloudflare: Change `cloudflare_record` type to ForceNew
@stack72 stack72 merged commit c59303a into hashicorp:master Feb 27, 2016
@stack72 stack72 deleted the f-cloudflare-type-forcenew branch February 27, 2016 00:53
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

claudflare do not allow changing record type
2 participants
@stack72 @jen20